Did the Supreme Court correctly balance the constitutional tension
between the free excercise and establishment clauses of the First
Amendment in its Locke v. Davey (2004) decision?

Yes. A state should have the right to try to abide by its own
constitution, in an effort to meet the requirements of the
establishment clause, by not providing funds for religious study--even
when it does provide funds for non-religious study.